Scale utils, bidirectional adapters #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hoytech
approved these changes
Mar 16, 2024
Contributor
hoytech
left a comment
hoytech
left a comment
There was a problem hiding this comment.
Love it! Abstracting the scaling is a great idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated decimal conversion logic in Chainlink/Pyth/Redstone is refactored to
ScaleUtils. Adapters now callfunction calcScale(uint8 baseDecimals, uint8 quoteDecimals, uint8 feedDecimals)to getpriceScaleandfeedScale, packed into a wrapped uint256. The inverse pricing logic is now in the library. This allows us to get bidirectional adapters for free.