[BAEL-3221] unmarshalling dates using JAXB - examples #7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalin-burcea
force-pushed
the
BAEL-3221
branch
from
83785b1 to
c97d364
Compare
ashleyfrieze
suggested changes
Sep 1, 2019
| private XMLGregorianCalendar published; | ||
|
|
||
| public Book() { | ||
| } |
There was a problem hiding this comment.
Do we need this constructor? There are no other constructors, so you get the default one for free.
| private Date published; | ||
|
|
||
| public Book2() { | ||
| } |
| private LocalDateTime published; | ||
|
|
||
| public Book3() { | ||
| } |
|
|
||
| public class DateAdapter extends XmlAdapter<String, Date> { | ||
|
|
||
| private final SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); |
There was a problem hiding this comment.
This should probably be static and have a BLOCK CAPITAL name.
|
|
||
| @Override | ||
| public String marshal(Date v) { | ||
| synchronized (dateFormat) { |
There was a problem hiding this comment.
I appreciate that this is not threadsafe... would it be safer/simpler to make the yyyy-MM-dd... the private static final thing and create a new SimpleDateFormat object every time?
| System.out.println(book2); | ||
| System.out.println(book3); | ||
| } catch (JAXBException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
This is IDE generated code... could we avoid the try/catch here and just let main throw an Exception?
Or would be better illustrating all this using unit tests, rather than a main method?
catalin-burcea
force-pushed
the
BAEL-3221
branch
from
c97d364 to
73e45ac
Compare
catalin-burcea
force-pushed
the
BAEL-3221
branch
from
73e45ac to
b7e8325
Compare
ashleyfrieze
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.