Removing "tabs" permission (firefox)#21
Merged
ettoolong merged 1 commit intoettoolong:masterfrom Jul 16, 2020
denilsonsa:patch-2
Merged
Removing "tabs" permission (firefox)#21ettoolong merged 1 commit intoettoolong:masterfrom denilsonsa:patch-2
ettoolong merged 1 commit intoettoolong:masterfrom
denilsonsa:patch-2
Conversation
According to the documentation, `tabs` permission is only needed when reading URL, title or favicon from a tab. None of this is required for this extension, so this permission can be safely removed. After this change, the browser will tell the user this extension doesn't need any special permission. If this extension ever needs such kind of privilege, it should instead declare `activeTab` permission, that grants extra access only to the current tab and only when the extension is used. * https://developer.chrome.com/extensions/windows * https://developer.chrome.com/extensions/tabs * https://developer.chrome.com/extensions/activeTab * https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs * https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission Bonus: for convenience, I've also bumped the version number to 0.1.0. This commit is the firefox version of the pull-request #20 Sidenote: it would be nice to merge both firefox and chrome codebases into a single branch.
Owner
|
v0.1.0 updated, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation,
tabspermission is only needed when reading URL, title or favicon from a tab. None of this is required for this extension, so this permission can be safely removed. After this change, the browser will tell the user this extension doesn't need any special permission.If this extension ever needs such kind of privilege, it should instead declare
activeTabpermission, that grants extra access only to the current tab and only when the extension is used.Bonus: for convenience, I've also bumped the version number to 0.1.0.
This commit is the firefox version of the pull-request #20
Sidenote: it would be nice to merge both firefox and chrome codebases into a single branch.