Add option to disable env var interpolation in configs #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZipFile
force-pushed
the
feature/optional-config-env-var-resolution
branch
from
1fba4b7 to
6c60245
Compare
ZipFile
force-pushed
the
feature/optional-config-env-var-resolution
branch
from
6c60245 to
b2f86ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env var interpolation for config files were introduced in #467, but no option to disable this feature were introduced. This PR fixes #857 by adding option to disable this functionality by handling
envs_required=None. Minor refactoring to improve performance of used private methods (cdef-ify) + removing Python 2 legacy.