Improve display of multiple taxonomies values in policy builder UI#8234
Merged
lucanovera merged 6 commits intoMay 19, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ve-UI-UX-for-multiple-categories-in-a-policy-block
kruulik
approved these changes
May 19, 2026
Contributor
kruulik
left a comment
There was a problem hiding this comment.
Works great! Tested on nightly, couldn't find any issues.
lucanovera
added a commit
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3783
Description Of Changes
Reworks the values input on a match condition (the "Match" node in the access-policy editor canvas) so users can comfortably select and review many taxonomy values at once. Previously the field used an antd multi-select with
maxTagCount={1}, which collapsed every selection past the first into a+Nindicator — making it effectively impossible to see what was selected when matching against 5–10+ data categories.The field now follows the chip + add pattern used by the data-discovery
TaxonomySelectCell: each selected value renders as its own closable chip and a+"addable" tag opens a full multi-select in place. Closing the editor (click outside) collapses back to the chip list. Because the chip list can grow vertically, the React Flow canvas now sizes condition nodes from their real measured DOM height instead of a hard-coded 310px — so a tall match node pushes its siblings down instead of overlapping them.Code Changes
ConditionValuesField.tsxinfeatures/access-policies/:+add tag.+, swaps to the appropriate taxonomy multi-select (DataCategorySelect/DataUseSelect/DataSubjectSelect/SystemGroupSelect/CustomTaxonomySelect) opened inmode="multiple", returning to the chip list on blur.useTaxonomies(built-in taxonomies); falls back to the raw fides_key for system groups and custom taxonomies.MatchNode.tsx: removed the inlinerenderValuesSelecthelper and its five taxonomy-select imports; the form field now renders<ConditionValuesField />.AccessPolicyEditor.tsx:nodeSizesmemo readsnode.measured?.height(populated by React Flow after the node mounts) and feeds it into the dagre layout. The previous hard-coded 310 (condition) / 380 (constraint) values remain as fallbacks for the first paint before measurement is available. As soon as a measurement is available — or whenever a chip is added/removed and the node re-measures — dagre re-runs and positions update.Steps to Confirm
/access-policies/newor any existing policy).Data categoriesas the taxonomy.+tag in the values field and select 8–10 categories. Confirm:×, all of them visible.×removes that single value.Data uses,Data subjects,System groups, and a custom taxonomy to confirm all five wrapper variants render correctly.Pre-Merge Checklist
CHANGELOG.mdupdated