Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 19, 2025

Ticket ENG-1626

Description Of Changes

Adds unit tests for the RequestTableActions.tsx component. Tests both which action is shown as well as the interactions with each action.

Test Suites (21 tests)

  • Action Visibility (13 tests): Validates correct button visibility for all privacy request statuses (pending, duplicate, identity_unverified, requires_input, approved, denied, in_processing, complete, paused, error, canceled, awaiting_email_send, requires_manual_finalization)
  • Loading States (2 tests): Verifies buttons are disabled and show loading indicators when mutations are in progress
  • Complete User Flows (4 tests): End-to-end tests for approve, deny, delete, and finalize actions (button click → modal open → confirm → mutation called → modal close)
  • Keyboard Navigation (2 tests): Ensures buttons are accessible via keyboard (tab navigation and Enter key activation)

Key Features Tested

  • Status-based conditional rendering of action buttons
  • Modal open/close behavior for all actions
  • Loading state handling across all buttons
  • Full user interaction flows with proper state management
  • Keyboard accessibility compliance

Code Changes

  • Added RequestTableActions.test.tsx

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 19, 2025 7:22am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 19, 2025 7:22am

@lucanovera lucanovera marked this pull request as ready for review December 19, 2025 07:22
@lucanovera lucanovera requested a review from a team as a code owner December 19, 2025 07:22
@lucanovera lucanovera requested review from speaker-ender and removed request for a team December 19, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants