Skip to content

Conversation

@tvandort
Copy link
Contributor

@tvandort tvandort commented Dec 12, 2025

Ticket FIDES-2059

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@tvandort tvandort requested review from a team as code owners December 12, 2025 21:25
@tvandort tvandort requested review from gilluminate and thabofletcher and removed request for a team December 12, 2025 21:25
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 12, 2025

Skipped: This PR changes more files than the configured file change limit: (122 files found, 100 file limit)

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Dec 12, 2025 9:25pm
fides-privacy-center Ignored Ignored Dec 12, 2025 9:25pm

@tvandort tvandort changed the base branch from main to release-2.67.2 December 12, 2025 21:25
@tvandort tvandort added the do not merge Please don't merge yet, bad things will happen if you do label Dec 12, 2025
@cypress
Copy link

cypress bot commented Dec 12, 2025

fides    Run #13623

Run Properties:  status check passed Passed #13623  •  git commit 35d70ff18e: Update to patched versions.
Project fides
Branch Review release-2.67.3
Run status status check passed Passed #13623
Run duration 00m 52s
Commit git commit 35d70ff18e: Update to patched versions.
Committer Thomas Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

@gilluminate
Copy link
Contributor

@tvandort this should be merged to main and then cherry-picked to release, not the other way around. Also, didn't we just do the opposite of this recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Please don't merge yet, bad things will happen if you do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants