-
Notifications
You must be signed in to change notification settings - Fork 87
ENG-1952 Add OAuth2 HTTP client with DPoP support #7038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
b2c10ff to
a3add0b
Compare
Greptile OverviewGreptile SummaryThis PR introduces a minimal Okta HTTP client with OAuth2 Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 3 comments
|
|
||
| Deliberately scoped: This client lives in connectors/, not in the SaaS framework. | ||
| If we later need a generic private_key_jwt + DPoP auth strategy for SaaS connectors, | ||
| we will extract it from this iplementation with a clear product decision and 2-3 use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: "iplementation" is misspelled
| we will extract it from this iplementation with a clear product decision and 2-3 use | |
| we will extract it from this implementation with a clear product decision and 2-3 use |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (96.72%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7038 +/- ##
==========================================
+ Coverage 87.03% 87.07% +0.03%
==========================================
Files 528 529 +1
Lines 34666 34788 +122
Branches 4005 4021 +16
==========================================
+ Hits 30172 30290 +118
- Misses 3620 3622 +2
- Partials 874 876 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3add0b to
5d1ea7a
Compare
Ticket ENG-1952
Description Of Changes
This work introduces a minimal Okta HTTP client with full support for OAuth2
private_key_jwtauthentication and DPoP — functionality not provided by the Okta SDK. It also adds a comprehensive suite of unit tests. This client is the foundation for the OAuth2 migration required to properly secure the Okta Identity Provider Monitor.Code Changes
OktaHttpClientimplementing OAuth2private_key_jwt+ DPoP authentication.list_applications,list_all_applications) with cursor extraction from response headers.test_okta_http_client.pywith full mock-based coverage for initialization, authentication, pagination, helper methods, and error paths.Steps to Confirm
nox -s unit.Pre-Merge Checklist
nox -s demo -- dev