-
Notifications
You must be signed in to change notification settings - Fork 87
Updates to privacy notice sandbox #7023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryThis PR updates the privacy notice sandbox to align with recent Consent V3 API changes, replacing the Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 files reviewed, no comments
...nts/admin-ui/src/features/poc/privacy-notices-sandbox/components/ExperienceConfigSection.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| const { noticeKeyToHistoryMap, parentNoticeKeys } = useMemo(() => { | ||
| const historyMap = new Map<string, string>(); | ||
| const parentMap = new Map<string, string>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like parentMap is being used for anything anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah you're right, will remove. thanks!
gilluminate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of nit-picks, but otherwise looking good.
…onents/ExperienceConfigSection.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
no ticket
Description Of Changes
We recently made some changes to the consent v3 API, so we need to update the privacy notice sandbox accordingly. The API
override_modequery param changed topolicy. Old name -> new name:descendants->cascade_downancestors->cascade_upall->cascade_up_and_downThis PR also removes a lot of the complex cascading logic the UI had and delegates it all to the backend; no cascading will be done in the privacy notice checkbox tree, but rather the tree is reloaded from the backend response after preferences are saved. It also removes the "simulated data" tab as that has fallen behind and is no longer needed now that we have a working API.
Code Changes
override_modetopolicyproperty_idinput to allow retrieving an experience configured on a specific propertySteps to Confirm
N/A
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works