Add mocks and boilerplate UI for Okta monitors #7017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds boilerplate UI components and mock data for Okta infrastructure monitors in the action center. Created reusable hooks ( Key changes:
Issues found:
Confidence Score: 3/5
Important Files ChangedFile Analysis
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
...ta-discovery-and-detection/action-center/hooks/useDiscoveredInfrastructureSystemsColumns.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| interface UseDiscoveredInfrastructureSystemsColumnsConfig { | ||
| monitorId: string; | ||
| onTabChange: (tab: ActionCenterTabHash) => Promise<void>; |
Contributor
There was a problem hiding this comment.
style: onTabChange parameter is unused and should be removed
Comment on lines
32
to
50
| const handleAddSystem = useCallback( | ||
| async (systemId: string) => { | ||
| await addMonitorResultSystemsMutation({ | ||
| monitor_config_key: monitorId, | ||
| resolved_system_ids: [systemId], | ||
| }); | ||
| }, | ||
| [addMonitorResultSystemsMutation, monitorId], | ||
| ); | ||
|
|
||
| const handleIgnoreSystem = useCallback( | ||
| async (systemId: string) => { | ||
| await ignoreMonitorResultSystemsMutation({ | ||
| monitor_config_key: monitorId, | ||
| resolved_system_ids: [systemId], | ||
| }); | ||
| }, | ||
| [ignoreMonitorResultSystemsMutation, monitorId], | ||
| ); |
Contributor
There was a problem hiding this comment.
logic: missing error handling for mutation failures - these functions should check isErrorResult() and display error toasts like the similar pattern in DiscoveredSystemActionsCell.tsx:54-74
lucanovera
changed the title
gilluminate
approved these changes
Nov 21, 2025
Comment on lines
19
to
24
| onCell: (record: SystemStagedResourcesAggregateRecord) => ({ | ||
| onClick: () => { | ||
| window.location.href = rowClickUrl(record); | ||
| }, | ||
| style: { cursor: "pointer" }, | ||
| }), |
Contributor
There was a problem hiding this comment.
We've been moving away from this row click pattern in favor of the main column text being a link. Are you sure we should be using it in this boilerplate?
Contributor
Author
There was a problem hiding this comment.
nice catch, I'll remove that
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2088
Description Of Changes
Setups mocks responses for an Okta monitor. Creates boilerplate component and hook to handle action center results for infrastructure monitors.
Code Changes
Steps to Confirm
npm run msw:mockPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works