Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 21, 2025

Ticket ENG-1934

Description Of Changes

Set max width for classification dropdown popups to prevent them from becoming too wide with long descriptions.

Code Changes

  • Added popupMatchSelectWidth={600} to ClassificationSelect component
  • Added text ellipsis styling to taxonomy option descriptions to truncate overflow

Steps to Confirm

  1. Open the action center to a data store monitor result
  2. Click on a classification dropdown in the fields list (the [+] button or next to it)
  3. Verify the dropdown popup has a reasonable max width
  4. Verify long descriptions are truncated with ellipsis as you hover the options
image

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 21, 2025 6:03pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 21, 2025 6:03pm

@gilluminate gilluminate marked this pull request as ready for review November 21, 2025 17:13
@gilluminate gilluminate requested a review from a team as a code owner November 21, 2025 17:13
@gilluminate gilluminate requested review from lucanovera and removed request for a team November 21, 2025 17:13
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 21, 2025

Greptile Overview

Greptile Summary

This PR sets a max width of 500px for classification dropdown popups and adds text truncation for long descriptions. The popupMatchSelectWidth={500} prop correctly limits the dropdown width. However, the text ellipsis implementation is incomplete - it's missing whitespace-nowrap which is required for CSS text-overflow ellipsis to function properly.

Confidence Score: 3/5

  • Safe to merge after fixing the text ellipsis implementation
  • The max width implementation is correct, but the text ellipsis won't work without whitespace-nowrap, which means long descriptions will wrap instead of truncating as intended
  • TaxonomySelect.tsx needs the whitespace-nowrap class added for proper ellipsis behavior

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/common/dropdown/TaxonomySelect.tsx 3/5 Added text-ellipsis to description but missing whitespace-nowrap for proper ellipsis behavior
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ClassificationSelect.tsx 5/5 Added popupMatchSelectWidth={500} to set max dropdown width

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in preview link, looks good!

@gilluminate gilluminate added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit cafe4c2 Nov 21, 2025
47 checks passed
@gilluminate gilluminate deleted the gill/ENG-1934/set-a-max-with-for-the-data branch November 21, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants