-
Notifications
You must be signed in to change notification settings - Fork 87
Set max width for data classification dropdown popups #7015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR sets a max width of 500px for classification dropdown popups and adds text truncation for long descriptions. The Confidence Score: 3/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in preview link, looks good!
Ticket ENG-1934
Description Of Changes
Set max width for classification dropdown popups to prevent them from becoming too wide with long descriptions.
Code Changes
popupMatchSelectWidth={600}to ClassificationSelect componentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works