Skip to content

Conversation

@vcruces
Copy link
Contributor

@vcruces vcruces commented Nov 19, 2025

Ticket ENG-1741

Description Of Changes

Updated the admin UI to use the new MonitorActionResponse type for monitor result promotion endpoints. This change aligns the frontend with backend changes that standardize the response format for monitor actions.

Dependencies: This PR depends on https://github.com/ethyca/fidesplus/pull/2788 being merged first.

Code Changes

  • Updated addMonitorResultSystems mutation to return MonitorActionResponse instead of PromoteResourcesResponse
  • Updated addMonitorResultAssets mutation to return MonitorActionResponse instead of PromoteResourcesResponse

Steps to Confirm

  1. Ensure the fidesplus PR After saving edits to a system in the "View systems" page, warning modal about unsaved changes still appears #2788 is merged first
  2. Navigate to the Action Center in the admin UI
  3. Perform a "promote" action on monitor results (both website and datastore monitors)
  4. Verify no errors occur

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Nov 19, 2025 10:45pm
fides-privacy-center Ignored Ignored Nov 19, 2025 10:45pm

@vcruces vcruces added the do not merge Please don't merge yet, bad things will happen if you do label Nov 19, 2025
@vcruces
Copy link
Contributor Author

vcruces commented Nov 19, 2025

@greptileai

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Updated admin UI to use MonitorActionResponse type for promote endpoints, aligning with backend standardization
  • Changed response structure from single task_id to array-based task_ids format

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are minimal and well-contained, only updating TypeScript return types for two mutations. Since none of the consumers actually access the response data (they only check for errors), the structural change from task_id to task_ids has no impact on functionality
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/action-center.slice.ts Updated return types for addMonitorResultSystems and addMonitorResultAssets mutations from PromoteResourcesResponse to MonitorActionResponse

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@vcruces vcruces marked this pull request as ready for review November 19, 2025 22:37
@vcruces vcruces requested a review from a team as a code owner November 19, 2025 22:37
@vcruces vcruces requested review from speaker-ender and removed request for a team November 19, 2025 22:37
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@vcruces vcruces removed the do not merge Please don't merge yet, bad things will happen if you do label Nov 19, 2025
@vcruces vcruces added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 4157ec5 Nov 19, 2025
47 checks passed
@vcruces vcruces deleted the ENG-1741 branch November 19, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants