-
Notifications
You must be signed in to change notification settings - Fork 87
ENG-1741 - Updated promote endpoints to return MonitorActionResponse type #7004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile Summary
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Ticket ENG-1741
Description Of Changes
Updated the admin UI to use the new
MonitorActionResponsetype for monitor result promotion endpoints. This change aligns the frontend with backend changes that standardize the response format for monitor actions.Dependencies: This PR depends on https://github.com/ethyca/fidesplus/pull/2788 being merged first.
Code Changes
addMonitorResultSystemsmutation to returnMonitorActionResponseinstead ofPromoteResourcesResponseaddMonitorResultAssetsmutation to returnMonitorActionResponseinstead ofPromoteResourcesResponseSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works