Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LDFLAGS & CFLAGS exports in MSSQL local build instructions #5760

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Feb 14, 2025

Unticketed change (minor docs correction)

Description Of Changes

  • Changes the LDFLAGS and CFLAGS exports used to run build Fides with MSSQL support on macOS
  • The new exports use symlinks in their paths so that they don't have to be changed very time the openssl and freetds versions used by homebrew are updated. Homebrew manages these symlinks automatically.

Code Changes

  • No code changes

Steps to Confirm

  1. Test the updated build instructions at https://github.com/ethyca/fides/blob/daveqnet/unticketed/update-README/README.md#%EF%B8%8F-advanced-setup-for-microsoft-sql-server-mssql-support

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 9:08am

@daveqnet daveqnet marked this pull request as ready for review February 14, 2025 09:08
@daveqnet daveqnet self-assigned this Feb 14, 2025
@daveqnet daveqnet requested a review from Linker44 February 14, 2025 09:09
@daveqnet daveqnet merged commit a337457 into main Feb 14, 2025
12 checks passed
@daveqnet daveqnet deleted the daveqnet/unticketed/update-README branch February 14, 2025 12:22
Copy link

cypress bot commented Feb 14, 2025

fides    Run #12471

Run Properties:  status check passed Passed #12471  •  git commit a337457b9a: Update LDFLAGS & CFLAGS exports in MSSQL local build instructions (#5760)
Project fides
Branch Review main
Run status status check passed Passed #12471
Run duration 00m 51s
Commit git commit a337457b9a: Update LDFLAGS & CFLAGS exports in MSSQL local build instructions (#5760)
Committer Dave Quinlan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants