Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consent-banner-tcf-custom-notices.cy.ts #5752

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

gilluminate
Copy link
Contributor

Description Of Changes

Recently fixed this flaky test in the consent-banner-tcf.cy.ts tests but it made its way to this custom notices test file as well. It really isn't relevant at all to the custom notices to I'm just removing it to fix the reintroduction of flakiness.

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Feb 11, 2025 11:37pm

Copy link

cypress bot commented Feb 11, 2025

fides    Run #12374

Run Properties:  status check passed Passed #12374  •  git commit 69cb52f01e ℹ️: Merge d5b82aa83c19ebc51b504a70b98f2b0835336213 into 97c66275ab141c6315f9fb78bf22...
Project fides
Branch Review refs/pull/5752/merge
Run status status check passed Passed #12374
Run duration 00m 48s
Commit git commit 69cb52f01e ℹ️: Merge d5b82aa83c19ebc51b504a70b98f2b0835336213 into 97c66275ab141c6315f9fb78bf22...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@thingscouldbeworse thingscouldbeworse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩸

@gilluminate gilluminate merged commit 4107582 into main Feb 12, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/fix-custom-notices-test branch February 12, 2025 00:19
Copy link

cypress bot commented Feb 12, 2025

fides    Run #12378

Run Properties:  status check passed Passed #12378  •  git commit 410758265e: Update consent-banner-tcf-custom-notices.cy.ts (#5752)
Project fides
Branch Review main
Run status status check passed Passed #12378
Run duration 00m 49s
Commit git commit 410758265e: Update consent-banner-tcf-custom-notices.cy.ts (#5752)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants