-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ClassificationCategoryBadge icon spacing #5702
Merged
gilluminate
merged 2 commits into
main
from
gill/fix-classification-category-badge-icons
Jan 27, 2025
Merged
Fix ClassificationCategoryBadge icon spacing #5702
gilluminate
merged 2 commits into
main
from
gill/fix-classification-category-badge-icons
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
lucanovera
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks for the quick fix. Approved!
fides Run #11949
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5702/merge
|
Run status |
Passed #11949
|
Run duration | 00m 47s |
Commit |
42da36689c ℹ️: Merge ac1921a449786211263b1fff273edc55699c6a14 into b55ebb68e14af08a8e0a8014246d...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
fides Run #11950
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11950
|
Run duration | 00m 48s |
Commit |
fcb8bbf8c4: Fix ClassificationCategoryBadge icon spacing (#5702)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Changes made along with the color updates (#5668) caused an issue with icon spacing in these badges. This fix addresses that and restores the badge layout.
Code Changes
Before:
After: