Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassificationCategoryBadge icon spacing #5702

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jan 27, 2025

Description Of Changes

Changes made along with the color updates (#5668) caused an issue with icon spacing in these badges. This fix addresses that and restores the badge layout.

Code Changes

  • Restores flex properties on the badge

Before:
image

After:
image

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 8:43pm

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the quick fix. Approved!

Copy link

cypress bot commented Jan 27, 2025

fides    Run #11949

Run Properties:  status check passed Passed #11949  •  git commit 42da36689c ℹ️: Merge ac1921a449786211263b1fff273edc55699c6a14 into b55ebb68e14af08a8e0a8014246d...
Project fides
Branch Review refs/pull/5702/merge
Run status status check passed Passed #11949
Run duration 00m 47s
Commit git commit 42da36689c ℹ️: Merge ac1921a449786211263b1fff273edc55699c6a14 into b55ebb68e14af08a8e0a8014246d...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@gilluminate gilluminate merged commit fcb8bbf into main Jan 27, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/fix-classification-category-badge-icons branch January 27, 2025 21:23
Copy link

cypress bot commented Jan 27, 2025

fides    Run #11950

Run Properties:  status check passed Passed #11950  •  git commit fcb8bbf8c4: Fix ClassificationCategoryBadge icon spacing (#5702)
Project fides
Branch Review main
Run status status check passed Passed #11950
Run duration 00m 48s
Commit git commit fcb8bbf8c4: Fix ClassificationCategoryBadge icon spacing (#5702)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants