-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial web monitor support (fides) #5616
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
def1e7b
to
acd48ac
Compare
fides
|
Project |
fides
|
Branch Review |
refs/pull/5616/merge
|
Run status |
|
Run duration | 00m 47s |
Commit |
|
Committer | Adam Sachs |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (63.73%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5616 +/- ##
==========================================
- Coverage 87.20% 87.11% -0.09%
==========================================
Files 391 394 +3
Lines 24313 24402 +89
Branches 2632 2637 +5
==========================================
+ Hits 21201 21257 +56
- Misses 2537 2569 +32
- Partials 575 576 +1 ☔ View full report in Codecov by Sentry. |
677c322
to
6a58882
Compare
a9edc36
to
59f7f66
Compare
fa0dc96
to
2eff43c
Compare
ef8d8c7
to
99a5a85
Compare
@thingscouldbeworse had you taken a look at this fides-side PR? if so, and it looks good, would you mind giving an approval? thanks! |
src/fides/api/alembic/migrations/versions/021166731846_add_asset_table.py
Outdated
Show resolved
Hide resolved
src/fides/api/alembic/migrations/versions/c961528edfc6_add_website_connection_type.py
Outdated
Show resolved
Hide resolved
src/fides/api/alembic/migrations/versions/c961528edfc6_add_website_connection_type.py
Outdated
Show resolved
Hide resolved
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 48s |
Commit |
|
Committer | Adam Sachs |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Done alongside https://github.com/ethyca/fidesplus/pull/1782
Description Of Changes
StagedResource
db model to support web monitor fieldsAsset
table + model and some utility methodswebsite
as a system/connector type, which will be leveraged by aWebsiteMonitor
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works