Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial web monitor support (fides) #5616

Merged
merged 21 commits into from
Feb 18, 2025
Merged

initial web monitor support (fides) #5616

merged 21 commits into from
Feb 18, 2025

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Dec 17, 2024

Done alongside https://github.com/ethyca/fidesplus/pull/1782

Description Of Changes

  • model updates to StagedResource db model to support web monitor fields
  • add an Asset table + model and some utility methods
  • support website as a system/connector type, which will be leveraged by a WebsiteMonitor

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 4:54pm

@adamsachs adamsachs changed the title initial web monitor support (fides) initial web monitor support db model updates Dec 17, 2024
@adamsachs adamsachs changed the title initial web monitor support db model updates initial web monitor support (fides) Dec 17, 2024
Copy link

cypress bot commented Dec 17, 2024

fides    Run #12415

Run Properties:  status check passed Passed #12415  •  git commit ccdf094c14 ℹ️: Merge 712f1ff9eee3a9bd112b4517e56debcd0b9a5aeb into 410758265edbec57d7e2389c3907...
Project fides
Branch Review refs/pull/5616/merge
Run status status check passed Passed #12415
Run duration 00m 47s
Commit git commit ccdf094c14 ℹ️: Merge 712f1ff9eee3a9bd112b4517e56debcd0b9a5aeb into 410758265edbec57d7e2389c3907...
Committer Adam Sachs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 63.73626% with 33 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (5390a34) to head (fa7b016).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../fides/api/service/connectors/website_connector.py 0.00% 31 Missing ⚠️
src/fides/api/models/asset.py 95.55% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (63.73%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
- Coverage   87.20%   87.11%   -0.09%     
==========================================
  Files         391      394       +3     
  Lines       24313    24402      +89     
  Branches     2632     2637       +5     
==========================================
+ Hits        21201    21257      +56     
- Misses       2537     2569      +32     
- Partials      575      576       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs force-pushed the asachs/HJ-295_fides branch from 677c322 to 6a58882 Compare January 6, 2025 18:50
@adamsachs adamsachs force-pushed the asachs/HJ-295_fides branch 3 times, most recently from a9edc36 to 59f7f66 Compare January 23, 2025 18:37
@adamsachs adamsachs force-pushed the asachs/HJ-295_fides branch 3 times, most recently from fa0dc96 to 2eff43c Compare January 29, 2025 21:46
@adamsachs adamsachs force-pushed the asachs/HJ-295_fides branch from ef8d8c7 to 99a5a85 Compare January 30, 2025 18:17
@adamsachs adamsachs marked this pull request as ready for review February 12, 2025 16:12
@adamsachs
Copy link
Contributor Author

@thingscouldbeworse had you taken a look at this fides-side PR? if so, and it looks good, would you mind giving an approval? thanks!

@adamsachs adamsachs merged commit 14356da into main Feb 18, 2025
36 of 37 checks passed
@adamsachs adamsachs deleted the asachs/HJ-295_fides branch February 18, 2025 18:22
Copy link

cypress bot commented Feb 18, 2025

fides    Run #12504

Run Properties:  status check passed Passed #12504  •  git commit 14356dae79: initial web monitor support (fides) (#5616)
Project fides
Branch Review main
Run status status check passed Passed #12504
Run duration 00m 48s
Commit git commit 14356dae79: initial web monitor support (fides) (#5616)
Committer Adam Sachs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants