Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft Add task to sync a fides dataset with datahub -- initial version #5552

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Draft Add task to sync a fides dataset with datahub -- initial version #5552

wants to merge 2 commits into from

Conversation

erosselli
Copy link
Contributor

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:41am

@erosselli erosselli added the do not merge Please don't merge yet, bad things will happen if you do label Dec 2, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024 •
edited
Loading

fides    Run #11817

Run Properties:  status check failed Failed #11817  •  git commit eb0ddc700b ℹ️: Merge 92d18a94f7009d999586eadf980efbaa3bc2fd6a into 645916269abf74fb2813fcb0e923...
Project fides
Branch Review refs/pull/5552/merge
Run status status check failed Failed #11817
Run duration 01m 06s
Commit git commit eb0ddc700b ℹ️: Merge 92d18a94f7009d999586eadf980efbaa3bc2fd6a into 645916269abf74fb2813fcb0e923...
Committer erosselli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

@andres-torres-marroquin @erosselli
Update src/fides/api/service/connectors/datahub_connector.py
92d18a9 
Co-authored-by: erosselli <67162025+erosselli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erosselli @andres-torres-marroquin