Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning messages from slowapi and docker #5385

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Fix warning messages from slowapi and docker #5385

merged 6 commits into from
Oct 16, 2024

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Oct 16, 2024 •
edited
Loading

Description Of Changes

Fixes two warnings:

  1. docker build prints warnings during a build like: FromAsCasing: 'as' and 'FROM' keywords' casing do not match
  2. starlette.py prints a warning during fides startup like: starlette/config.py:66: UserWarning: Config file '.env' not found.

The docker warning is due to a mismatch in our Dockerfile, and the Starlette warning originates from the slowapi package which fixed this in their 0.9.1 update: laurentS/slowapi@aa9eb7a

Code Changes

  • update slowapi to 0.1.9 (see CHANGELOG, it's basically just this fix for the env file warning)
  • fix Dockerfile to use consistent casing
  • add a unit test for fides --version

Steps to Confirm

  • run nox -s dev and confirm no Docker warnings
  • build and run the fides image without a .env file and check logs do not contain the Starlette warning... (this is fairly hard to repro in dev environment, but trust me this is addressed)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:58am

@cypress Cypress
Copy link

cypress bot commented Oct 16, 2024 •
edited
Loading

fides    Run #10459

Run Properties:  status check passed Passed #10459  •  git commit a8f342acca ℹ️: Merge 8638add8447942b3543975a68e9ab79a02f6e818 into e55d71f66ed37d3980ff370ca908...
Project fides
Run status status check passed Passed #10459
Run duration 00m 39s
Commit git commit a8f342acca ℹ️: Merge 8638add8447942b3543975a68e9ab79a02f6e818 into e55d71f66ed37d3980ff370ca908...
Committer Neville Samuell
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@NevilleS NevilleS marked this pull request as ready for review October 16, 2024 00:55
thingscouldbeworse
thingscouldbeworse approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@thingscouldbeworse thingscouldbeworse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, may need to re-run failed jobs to get the front end CI check passing

erosselli
erosselli approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NevilleS NevilleS merged commit 4c9703e into main Oct 16, 2024
42 of 43 checks passed
@NevilleS NevilleS deleted the ns-fides-qol-fixes branch October 16, 2024 15:51
@cypress Cypress
Copy link

cypress bot commented Oct 16, 2024

fides    Run #10469

Run Properties:  status check passed Passed #10469  •  git commit 4c9703e9d4: Fix warning messages from slowapi and docker (#5385)
Project fides
Run status status check passed Passed #10469
Run duration 00m 38s
Commit git commit 4c9703e9d4: Fix warning messages from slowapi and docker (#5385)
Committer Neville Samuell
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thingscouldbeworse thingscouldbeworse thingscouldbeworse approved these changes

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NevilleS @thingscouldbeworse @erosselli