-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2768 Fix attempt #5295
Draft
erosselli
wants to merge
2
commits into
release-2.43.2
Choose a base branch
from
PROD-2768
base: release-2.43.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PROD-2768 Fix attempt #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
Project |
fides
|
Branch Review |
refs/pull/5295/merge
|
Run status |
|
Run duration | 00m 37s |
Commit |
|
Committer | erosselli |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.43.2 #5295 +/- ##
===============================================
Coverage 86.40% 86.40%
===============================================
Files 362 362
Lines 22763 22757 -6
Branches 3056 3055 -1
===============================================
- Hits 19669 19664 -5
Misses 2537 2537
+ Partials 557 556 -1 ☔ View full report in Codecov by Sentry. |
Reviewed looks good to move forward with testing for an alpha image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Attempts two different fixes for PROD-2768:
CORSMiddleware
, we're not sure how this could be causing the issue but since we only see it for PUT/POST requests, we think it could potentially be related. As a temporary workaround (to test the theory that the middleware's the issue), we're skipping getting CORS configs from the DB and pulling them only from env variables, which allows us to skip the somewhat hacky workaround introduced in 2.43.1Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works