Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3042: Refactor client applications into a monorepo with turborepo, extract fides-js into a standalone package, and improve privacy-center to load configuration at runtime #3105

Merged
merged 78 commits into from
May 5, 2023
Merged

3042: Refactor client applications into a monorepo with turborepo, extract fides-js into a standalone package, and improve privacy-center to load configuration at runtime #3105

Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
03001ab
initial integration with turborepo
eastandwestwind Apr 7, 2023
d1e611b
hoist fides consent as shared package
eastandwestwind Apr 9, 2023
7a2d12c
updates github and docker workflows to use turbo
eastandwestwind Apr 10, 2023
ef31735
progress on dockerfile, still failing
eastandwestwind Apr 10, 2023
bdbe958
adds turbo globally in clients
eastandwestwind Apr 13, 2023
bd7a906
adjust rollup config
eastandwestwind Apr 14, 2023
0d70867
package-lock
eastandwestwind Apr 14, 2023
624f83e
moves pc into same docker container as base fides image, when in dev …
eastandwestwind Apr 19, 2023
46d6f9f
fix some bugs with running test env
eastandwestwind Apr 19, 2023
6e7a4af
Gets pc running using test env. PC config is currently not being boun…
eastandwestwind Apr 19, 2023
ad8250c
cleanup and docs clarification
eastandwestwind Apr 20, 2023
b0389b6
add back user for security in PC docker, adjust dockerignore
eastandwestwind Apr 20, 2023
e51c624
remove unneeded dockerfile in PC
eastandwestwind Apr 20, 2023
5d2ae82
eliminate extra spaces in github workflow
eastandwestwind Apr 20, 2023
2907291
move cypress config up a level, fix lint issue with PC
eastandwestwind Apr 20, 2023
6a049d6
turn off unsafe-to-chain-command rule for eslint
eastandwestwind Apr 20, 2023
d956bf6
disable cypress/unsafe-to-chain-command across admin-ui and pc
eastandwestwind Apr 20, 2023
e7e4035
split out pc vs admin-ui cypress
eastandwestwind Apr 20, 2023
4f79763
remove unneeded cypress config file, remove ability to call cypress g…
eastandwestwind Apr 20, 2023
889da9f
remove other cy commands from root package.json
eastandwestwind Apr 20, 2023
991f9e2
cleanup, remove package-lock.json from within each workspace, turbo i…
eastandwestwind Apr 21, 2023
5b0f1f2
rename export-ui to export-admin-ui
eastandwestwind Apr 21, 2023
405e957
remove fides-consent build from getting copied into root fides
eastandwestwind Apr 21, 2023
399a679
remove unneeded turbo commands, adds README to clients, minor naming …
eastandwestwind Apr 21, 2023
7bcdc86
fixes cypress upload on failure, adds specific step for both admin-ui…
eastandwestwind Apr 21, 2023
ac78106
remove unneeded files
eastandwestwind Apr 22, 2023
f4ed02d
Refactor `fides-consent ` and `privacy-center` to support loading con…
NevilleS Apr 25, 2023
ae21bfe
Add a few more TODOs, for my notes
NevilleS Apr 25, 2023
fb8d12f
Fix naming of fides.global.js -> fides.js
NevilleS Apr 25, 2023
7569d62
Remove duplicate test page in fides-js package
NevilleS Apr 25, 2023
eea9bde
Fix frontend_checks.yml
NevilleS Apr 25, 2023
fe45154
Add file-level docs comment to fides.ts and adjust _Fides var scoping
NevilleS Apr 25, 2023
5775971
Fix lint errors
NevilleS Apr 25, 2023
b0c2b24
Format with prettier
NevilleS Apr 26, 2023
31f0f7a
Get privacy center cypress tests building (but failing)
NevilleS Apr 26, 2023
50d5a6a
Fix privacy-center Docker build
NevilleS Apr 26, 2023
cb16c6a
Update Cypress CI workflows for admin-ui and privacy-center
NevilleS Apr 26, 2023
eede348
Add npm build to Cypress CI
NevilleS Apr 26, 2023
bfed8ac
Tidy up unnecessary jest hacks
NevilleS Apr 26, 2023
1d62386
Update typescript-cookie
NevilleS Apr 26, 2023
18eaa63
Add placeholder jest suite to fides-js
NevilleS Apr 26, 2023
4724da6
Merge branch 'main' of github.com:ethyca/fides into 771-turborepo-poc
NevilleS Apr 29, 2023
f189cd2
Finish merging in main and cleanup fides-js & sample-app projects a bit
NevilleS Apr 30, 2023
cae0933
Add cypress-e2e to turborepo
NevilleS Apr 30, 2023
4b03b79
Remove cypress-e2e and sample-app from turborepo (for now)
NevilleS Apr 30, 2023
fdf22aa
Fix sample-app build
NevilleS Apr 30, 2023
c7767dd
Add Cypress.loadConfigFixture that dynamically loads privacy center c…
NevilleS Apr 30, 2023
6f9989e
Fix privacy center cypress tests to use loadConfigFixture
NevilleS Apr 30, 2023
34a087e
Add details unit tests for lib/cookie
NevilleS Apr 30, 2023
b58915b
Format & lint
NevilleS Apr 30, 2023
aabe0fa
Continue linting & cleaning up
NevilleS Apr 30, 2023
a86fecc
Fix formatting
NevilleS Apr 30, 2023
3242ebf
Fix admin-ui cy:start to run a test build to disable proxy rewrites
NevilleS Apr 30, 2023
84c92e7
Try to run client unit & cypress tests in parallel per package
NevilleS Apr 30, 2023
4b62776
Fix workflow syntax
NevilleS Apr 30, 2023
a3f91ae
Add test:ci script to fides-js
NevilleS Apr 30, 2023
361d1d1
Add explicit jest-environment-jsdom to fides-js package
NevilleS Apr 30, 2023
b13c30a
Change jsDom -> jsdom... hope that works in CI
NevilleS Apr 30, 2023
faab9e7
Fix typo in dockerignore
NevilleS May 1, 2023
3dfe42f
Merge branch 'main' of github.com:ethyca/fides into 771-turborepo-poc
NevilleS May 3, 2023
73f7126
Copy rollup.config.js back from main
NevilleS May 3, 2023
b9b931d
Use rollup to bundle fides.js instead
NevilleS May 3, 2023
afbfbef
Remove tsup dependency
NevilleS May 3, 2023
3137010
Attempt to target es5 again using rollup
NevilleS May 3, 2023
10ca455
Explicitly target es2015, remove tsup entirely
NevilleS May 3, 2023
b551303
Fail fides-js build if the bundle size becomes too large
NevilleS May 3, 2023
f7c750e
Fix log for bundle size check
NevilleS May 3, 2023
7c0962e
remove unneeded build dependencies in turbo pipelines
eastandwestwind May 3, 2023
3fbe2c4
removing some todos and unneeded code, adding comments
eastandwestwind May 3, 2023
cc0d6de
pull latest main, fix conflicts
eastandwestwind May 3, 2023
2212575
Add a .prettierignore file to sample app (so I don't forget)
NevilleS May 3, 2023
6b295f8
Run prettier on fides-js files
NevilleS May 3, 2023
12788ea
Remove TODO, link to a follow-up issue
NevilleS May 3, 2023
e1961db
Update additional TODOs for follow-up work on this
NevilleS May 3, 2023
c41e7b6
Final (?) linting and formatting
NevilleS May 3, 2023
603629d
Fix some lint & build warnings
NevilleS May 3, 2023
0c1bb27
Fix volume mounts for `nox -s dev -- ui pc`
NevilleS May 4, 2023
9149f2f
Update turbo dev & test pipelines to be "persistent" and depend on "^…
NevilleS May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test:ci script to fides-js
  • Loading branch information
@NevilleS
NevilleS committed Apr 30, 2023
commit a3f91aef45d2bbc503c40b6ad9d463814da9e3b1
4 changes: 2 additions & 2 deletions clients/fides-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"dev": "npm run build -- --watch",
"clean": "rm -rf dist",
"lint": "eslint . --ext .ts,.tsx",
"test": "jest",
"test:watch": "jest --watch"
"test": "jest --watch",
"test:ci": "jest"
},
"repository": {
"type": "git",
Expand Down