Allow users to configure the webserver port #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobertKeyser ready for your eyes! 🙂 |
seanpreston
approved these changes
Nov 28, 2022
|
Nice change thanks @ThomasLaPiana |
RobertKeyser
approved these changes
Nov 28, 2022
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
LJ-378-snap-dsr-erasure-ignore-400
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | Facundo Lopez Janza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Facundo Lopez Janza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1797
Code Changes
portparam to thestart_webserverfunctionfides webservercommand for a portSteps to Confirm
fides webserver --port 8081, observe the logged configuration values and confirm. Additionally check used ports and notice 8081 is being usedPre-Merge Checklist
CHANGELOG.mdDescription Of Changes
This is a small QOL fix to make deployments easier
Logs should now look something like this when using the flag: