Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fideslog to v1.2.10 #1666

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Bump fideslog to v1.2.10 #1666

merged 2 commits into from
Nov 3, 2022

Conversation

PSalant726
Copy link
Contributor

@PSalant726 PSalant726 commented Nov 2, 2022 •
edited
Loading

Closes #1660

Code Changes

  • Bump fideslog to v1.2.10

Steps to Confirm

  1. Buy a Windows machine
  2. Using the Windows machine, start fides
  3. Observe that errors are no longer thrown when sending analytics events synchronously

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@PSalant726
Bump fideslog to v1.2.10
3830113 
Fixes the event loop policy on Windows machines
@PSalant726 PSalant726 added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 2, 2022
@PSalant726 PSalant726 self-assigned this Nov 2, 2022
@ThomasLaPiana
Copy link
Contributor

@PSalant726 LGTM! Thanks for this

test> fides --version
fides, version 2.0.0.post0.dev7
test> fides parse
Loading config from: .fides/fides.toml
Directory './.fides' already exists.
Configuration file already exists: ./.fides/fides.toml
To learn more about configuring fides, see:
        https://ethyca.github.io/fides/installation/configuration/
Loading resource manifests from: .fides/
No manifests found to parse, skipping...
test>

@ThomasLaPiana ThomasLaPiana merged commit 62e30fb into main Nov 3, 2022
@ThomasLaPiana ThomasLaPiana deleted the bump-fideslog-to-1.2.10 branch November 3, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees

@PSalant726 PSalant726

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The event_loop bug is back on Windows
2 participants
@PSalant726 @ThomasLaPiana