Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Subject Requests" -> "Privacy Requests" and "Datastore Connections" -> "Connections" #1622

Merged
merged 5 commits into from
Oct 31, 2022

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Oct 31, 2022

Closes #1586

Walkthrough

Fides.Admin.UI.-.Privacy.Requests.-.31.October.2022.mp4

Docs Site Screenshots

Several pages updated, but here are the main two:
image
image

NOTE: You'll see that the UI screenshots in those pages aren't updated. This is expected - the docs site itself is undergoing heavy updates. That's actually why I want to get this change in now, so we don't have to redo all the screenshots again later!

Code Changes

  • Update navigation, headers, buttons, drop-downs, and other references to "Subject Request", "DSR", etc.
  • Update navigation, headers, buttons, drop-downs, and other references to "Datastore" or "Datastore Connection"
  • Update docs for Subject Requests
  • Update docs for Datastore Connections
  • Update automated tests to expect new naming, IDs, etc.

Steps to Confirm

  • Use nox -s test_env to test the privacy request and connection management screens
  • Use `nox -s

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created:
  • Update CHANGELOG.md

Description Of Changes

This is a minor rename of some of the features in the UI as part of our 2.0 release, so that it's consistent with the long-term vision for these features in the roadmap ahead. The product & documentation teams have put a lot of thought into where they want to improve the navigation and terminology in the app, and I offered to do this copy editing right now so that it'd be less of a chore to redo a lot of the documentation work (especially screenshots!) in the months to come.

This is mainly just copy edits, though in some places the test code expected specific copy to run automation suites, etc. Lots of files changed, but the risk of these seems pretty minimal...

@NevilleS NevilleS requested a review from a team October 31, 2022 15:47
@NevilleS NevilleS marked this pull request as draft October 31, 2022 15:49
@NevilleS NevilleS changed the title Ns 1586 update nav bar Rename "Subject Requests" -> "Privacy Requests" and "Datastore Connections" -> "Connections" Oct 31, 2022
@NevilleS NevilleS marked this pull request as ready for review October 31, 2022 16:41
@NevilleS
Copy link
Contributor Author

Got the 👍 from @malaethyca on the copy & nav changes, so this is ready to come in.

Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the verbiage updates.

@NevilleS NevilleS merged commit f9b2ef5 into main Oct 31, 2022
@NevilleS NevilleS deleted the ns-1586-update-nav-bar branch October 31, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation bar changes
2 participants