Support ES modules #145
Merged
Support ES modules #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PureScript 0.15 has been released and the module system used in the output JavaScript has been changed from CommonJS to ES Modules. I was wondering if you could this PR could be merged. |
|
I tried this change and it seems to make |
|
@ethul In case you read this: Are you open to merge or add maintainers to this repository or would you rather prefer a fork being published on npm? :) |
andys8
added a commit
to andys8/craco-purescript-loader
that referenced
this pull request
Aug 5, 2022
Relying on <ethul/purs-loader#145> fork to support es modules.
|
+1 ! ... I came up with exactly the same fix, and was about to submit a PR until I found this one :) |
|
Thanks for the reminder for this. I have fallen a bit behind on PRs, but I
will take a look—apologies for the delay!
…On Mon, Sep 19, 2022 at 18:45 Olivier Guimbal ***@***.***> wrote:
+1 !
... I came up with exactly the same fix, and was about to submit a PR
until I found this one :)
—
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVRS5MYCZFBFP5MHGJYGDV7DUJRANCNFSM4MOP3GFA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This looks great, apologies again for the delay on this. I will endeavor to be more prompt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly adjusts the regexps used to rewrite require paths in modules read from the output directory so it supports both CJS and ES modules, in anticipation of purescript/purescript#3791.