replace "enable_l2_blob" with "l2BlobTime" #60
Conversation
blockchaindevsh
force-pushed
the
rm_enable_l2_blob
branch
from
d0e06f7 to
47fe57e
Compare
blockchaindevsh
force-pushed
the
rm_enable_l2_blob
branch
from
47fe57e to
a1198fb
Compare
blockchaindevsh
force-pushed
the
rm_enable_l2_blob
branch
from
a1198fb to
e117904
Compare
| @@ -362,13 +362,13 @@ func BuildBlocksValidator(log log.Logger, cfg *rollup.Config, runCfg GossipRunti | |||
|
|
|||
| if blockVersion.HasBlobProperties() { | |||
| // [REJECT] if the block is on a topic >= V3 and has a blob gas used value that is not zero | |||
| if payload.BlobGasUsed == nil || (!cfg.IsL2BlobEnabled() && *payload.BlobGasUsed != 0) { | |||
| if payload.BlobGasUsed == nil || (!cfg.IsL2Blob(uint64(payload.Timestamp)-cfg.BlockTime) && *payload.BlobGasUsed != 0) { | |||
There was a problem hiding this comment.
Why we need to subtract the blockTime (2s) here?
There was a problem hiding this comment.
Because the geth side is always checking against the parent block to test HF activation of the current block. That's why the parameter for IsL2Blob is named parentTime.
zhiqiangxu
force-pushed
the
rm_enable_l2_blob
branch
from
26b8cff to
4c717c9
Compare
blockchaindevsh
force-pushed
the
rm_enable_l2_blob
branch
2 times, most recently
from
79effd6 to
73b58c0
Compare
blockchaindevsh
force-pushed
the
rm_enable_l2_blob
branch
from
73b58c0 to
cfc688c
Compare
|
@qizhou The latest commit moves |
| EnableL2Blob bool `json:"enable_l2_blob,omitempty"` | ||
| DACURLS []string `json:"dac_urls,omitempty"` | ||
| L2GenesisBlobTimeOffset *hexutil.Uint64 `json:"l2GenesisBlobTimeOffset,omitempty"` | ||
| DACURLS []string `json:"dac_urls,omitempty"` |
There was a problem hiding this comment.
As I understand it, we might want to remove the DACURLS from the rollup configuration, or do we want to do it in a seprate PR?
There was a problem hiding this comment.
Yeah, there's a separate issue for that(no PR yet).
|
@qizhou There's a commit after your first approval, after you approve again, I'll merge and create another PR that moves DAC away from rollup config(which is depending on this PR being merged first). |
This PR replace "enable_l2_blob" with "l2BlobTime", following geth upgrade style.