Update registry to allow 64 byte uris #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
web3-dev
branch
from
4d316ce
to
c57bb37
Compare
|
merging since minor tweak to vyper contract - needed for ethereum/web3.py#1125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Previous vyper registry only allowed URI's up ot 32 bytes - tweaked registry to allow up to 64 byte URIs. Still not ideal since this takes the registry implementation one step further away from the ERC1319 standard, as well as doesn't allow for http uris to be stored on-chain (since they're likely longer than 64 bytes) - but it should accommodate all IPFS uris - which is sufficient for the workshop
Cute Animal Picture