fix(erc20_bloater): fix progress reset on restart - units mismatch bug #177
+51
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pk910 targetting I just caught this after some weird observations in the spamoor instance. I missed testing the resetting part with decent progress.. MB! |
The erc20_bloater scenario was losing progress (halving each restart) due to a semantic mismatch between the Solidity contract and Go code: - Contract's `nextStorageSlot` stores ADDRESS INDEX (count of addresses bloated) - Go code was treating this as SLOT COUNT (addresses × 2) This caused a destructive bug on restart: 1. Read address index X from contract 2. Treat X as slot count (wrong units) 3. Call buildBloatTx(..., X/2, ...) - dividing by SlotsPerBloatCycle 4. Contract sets nextStorageSlot = X/2 - permanently halving progress! Fix: - Rename `startSlot` → `nextAddressIndex` for clarity - Rename `targetSlots` → `targetAddresses` - Remove the /SlotsPerBloatCycle division when calling buildBloatTx - Fix progress calculations to properly convert addresses to bytes/GB Tested with Geth in dev mode: progress now correctly resumes instead of halving.
CPerezz
force-pushed
the
fix/erc20-bloater-progress-reset
branch
from
9b76c55 to
839b3b2
Compare
pk910
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nextStorageSlotreturns an address index (each address = 2 storage slots = 64 bytes), but the code was treating it as a raw slot numberRoot Cause
The variable
startSlotwas semantically incorrect - it was actually tracking address indices, not storage slots. Each "bloat cycle" creates 2 storage slots per address, so the progress calculation was off by a factor of 2.Changes
startSlot→nextAddressIndexfor claritySlotsPerBloatCyclemultiplier