Skip to content

fix(MultiLine): enable chart updates when toggling series visibility #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Savid merged 2 commits into from
Nov 15, 2025
Merged

fix(MultiLine): enable chart updates when toggling series visibility #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6f635
fix(MultiLine): enable chart updates when toggling series visibility
Savid Nov 15, 2025
2de830d
refactor(MultiLine): make notMerge configurable with prop
Savid Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Charts/MultiLine/MultiLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export function MultiLineChart({
enableSeriesFilter = false,
relativeSlots,
syncGroup,
notMerge = true,
}: MultiLineChartProps): React.JSX.Element {
// Get callback ref for crosshair sync
const chartRef = useSharedCrosshairs({ syncGroup });
Expand Down Expand Up @@ -767,7 +768,7 @@ export function MultiLineChart({
minHeight: typeof _height === 'number' && !(showLegend && series.length > 1) ? _height + 52 : _height,
pointerEvents: 'auto',
}}
notMerge={false}
notMerge={notMerge}
opts={{ renderer: 'canvas' }}
/>
</div>
Expand Down
7 changes: 7 additions & 0 deletions src/components/Charts/MultiLine/MultiLine.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,4 +302,11 @@ export interface MultiLineChartProps {
* Charts with the same syncGroup will have synchronized tooltips and axis pointers
*/
syncGroup?: string;
/**
* Whether to merge or replace chart options on update
* When true, completely replaces chart options (recommended for toggling series)
* When false, merges new options with existing chart state (better performance for frequent updates)
* @default true
*/
notMerge?: boolean;
}
3 changes: 3 additions & 0 deletions src/pages/ethereum/live/components/BlobDataAvailability/BlobDataAvailability.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ function BlobDataAvailabilityComponent({
tooltipTrigger="axis"
tooltipFormatter={continentalTooltipFormatter}
animationDuration={0}
notMerge={false}
/>
</div>
</div>
Expand Down Expand Up @@ -232,6 +233,7 @@ function BlobDataAvailabilityComponent({
tooltipTrigger="axis"
tooltipFormatter={continentalTooltipFormatter}
animationDuration={0}
notMerge={false}
/>
</div>
</div>
Expand All @@ -248,6 +250,7 @@ function BlobDataAvailabilityComponent({
tooltipTrigger="axis"
tooltipFormatter={continentalTooltipFormatter}
animationDuration={0}
notMerge={false}
/>
</div>
</>
Expand Down