Skip to content

fix: clear map datapoints when slot ends #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcm merged 1 commit into from
Nov 15, 2025
Merged

fix: clear map datapoints when slot ends #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/components/Charts/Map2D/Map2D.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,15 @@ function Map2DChartComponent({
previousPointsLengthRef.current = 0;
}

// Early exit: if points array length hasn't changed and we're not resetting, skip
if (!isReset && points.length === previousPointsLengthRef.current) {
// If points array is empty, clear accumulated points (slot ended)
const isClearing = points.length === 0 && allSeenPointsRef.current.size > 0;
if (isClearing) {
allSeenPointsRef.current.clear();
previousPointsLengthRef.current = 0;
}

// Early exit: if points array length hasn't changed and we're not resetting or clearing, skip
if (!isReset && !isClearing && points.length === previousPointsLengthRef.current) {
return;
}

Expand All @@ -194,8 +201,8 @@ function Map2DChartComponent({
}
});

// Only update if we have new points or just reset
if (!hasNewPoints && !isReset) return;
// Only update if we have new points, just reset, or clearing
if (!hasNewPoints && !isReset && !isClearing) return;

// Update our tracking ref
previousPointsLengthRef.current = points.length;
Expand Down