fix: emit caplin bootnode override and enable local discovery#1452
Open
MysticRyuujin wants to merge 1 commit into
Open
fix: emit caplin bootnode override and enable local discovery#1452MysticRyuujin wants to merge 1 commit into
MysticRyuujin wants to merge 1 commit into
Conversation
- a non-null bootnode_enr_override was silently dropped; emit it as --sentinel.bootnodes like other CL launchers - add --local-discovery unconditionally, matching lighthouse/grandine/teku private-discovery flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the Caplin launcher's peer discovery on private networks:
bootnode_enr_override. The override (set when bootnodoor is the network bootnode) was assigned tobootnode_argbut only thebootnode_contextspath ever appended--sentinel.bootnodes, so a non-null override was silently dropped and Caplin nodes never learned the bootnode. Restructured to match the other CL launchers (assignbootnode_arg, emit once at the end).--local-discovery. Caplin otherwise refuses to discover peers on private IPs. Added unconditionally in the base command, matching how the package sets the equivalent flags for Lighthouse/Grandine (--enable-private-discovery) and Teku (--p2p-discovery-site-local-addresses-enabled=true).Testing
Verified live on docker: 2× geth/caplin + bootnodoor — with these fixes both Caplins receive
--sentinel.bootnodes=<bootnodoor ENR>and connect to each other (previously 0 peers).