Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create helm chart for powfaucet #242

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Create helm chart for powfaucet #242

merged 3 commits into from
Oct 18, 2023

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Oct 17, 2023

No description provided.

@pk910 pk910 requested a review from skylenet as a code owner October 17, 2023 14:36
@pk910 pk910 marked this pull request as draft October 17, 2023 14:36
@pk910 pk910 marked this pull request as ready for review October 18, 2023 08:29
skylenet
skylenet approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@skylenet skylenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I like that you chose a StatefulSet instead of using a Deployment. This will have better guarantees that only 1 pod is always running which in this case is great to avoid any nonce conflicts with the faucets ethereum address.

@skylenet
Copy link
Member

Oh, just a minor thing. Maybe add a link to the main README.md?

@pk910 pk910 merged commit 79d136d into master Oct 18, 2023
1 check passed
@pk910 pk910 deleted the pk910/powfaucet branch October 18, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylenet skylenet skylenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pk910 @skylenet