-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/reth ports #227
Fix/reth ports #227
Conversation
* feat(charts/xatu-mimicry): add probe * feat(charts/xatu-mimicry): add default captureDelay
* feat(chart/ethereum-node): add holesky network * feat(chart/ethereum-node): bump version * feat(chart/ethereum-node): bump sub charts * feat(chart/ethereum-node): bump sub charts
Could you please run |
@barnabasbusa should be ok now, thanks for the feedback as for #219, I just committed the changes myself, since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see the ci lint failing, does the chart bump need to be the last pushed commit? or is that a known issue and when you squash and merge to master it will take care of itself? |
Could you rebase master, and bump to 0.0.8 ? |
You gotta bump ethereum-nodes too, as you modified that too, then rerun the |
yeah, i'm sorry for the mess but i'm having issues running I'm getting a |
Looks like this PR now includes a lot more changes than a few commits before. I'm not really sure the rebase worked out the way we wanted it. |
yeah - I wrongfully rebased master on top of this branch... I'll scrap this and make a new PR from scratch since the changes are trivial. I'll also try running Thanks for your patience :') |
closing this in favour of #235 |
Closes #218
wsPort
value to8546
to reflect the default in Reth shown below:authPort
andwsAuthPort
by removing the latter, since Reth has only one singleauthrpc.port
flag