Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

cmd/swarm,pss,swap: fixed linter errors S1038/S1039 #2136

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

santicomp2014
Copy link
Contributor

This resolves #2135

Fixed linter issues

Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that linter got improved. Thanks for fixing issues. I have only one minor comment that is not crucial. LGTM.

Comment on lines 286 to 289
fmt.Print(fmt.Sprintf("bzzkey=%s", bzzkey[2:]), "\n")
fmt.Print(fmt.Sprintf("publicKey=%s", pubkeyhex), "\n")
}
fmt.Println(fmt.Sprintf("publicKeyCompressed=%s", pubCompressed))
fmt.Print(fmt.Sprintf("publicKeyCompressed=%s", pubCompressed), "\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these lines be in a simpler form fmt.Printf("...%s\n", ARGS...)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@ralph-pichler ralph-pichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santicomp2014 santicomp2014 merged commit d9fd8f3 into master Mar 13, 2020
@acud acud deleted the swarm-linter-fix branch March 13, 2020 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter fails on fmt.Print --> S1038/S1039 clauses
4 participants