-
Notifications
You must be signed in to change notification settings - Fork 110
api: Add bzz-feed-raw scheme to retrieve arbitary feed update #1959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not tested at all
fair enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me that only comments on exported functions are missing. Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantically I'm not sure why raw
was appended to feed
, as I'm not sure that its rawness
differs in any way from bzz-feed
at all (both return an octet stream mime type). So I find the naming confusing.
Personally I think we're better off adding this functionality into the normal Feed handler and just toggle it with a querystring param, even more so since feeds already have tweakable options through querystrings - do we really need to introduce a new scheme just in order to facilitate one type of request? I'm not sure I see the benefit.
@acud I think the relation between the data accessed by
Furthermore, Lastly, I'm not very happy with the use of query string parameters in the |
This PR adds an HTTP scheme
bzz-feed-raw
the enables direct retrieval of the raw chunk contents from a reference. The use case that prompted the change was the desire tocircumvent the lookup algorithm of feeds to access only a particular update if it exists, without having to wait for the additional lookups the algorithms execute to finish (and fail if there are no newer ones)