This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
api, chunk: progress bar support #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
acud
reviewed
Aug 8, 2019
|
@jmozah i added some comments in the body of the PR. |
|
@zelig In the GET API.. i currently send the entire tag structure as it is. @acud was talking about sending counters only based on Status(). I don't get it. Why should client be bothered about states? From the client perspective, he gets the counters and he decides what to do with them. This is the only thing remaining in this PR for now. |
janos
reviewed
Aug 9, 2019
janos
reviewed
Aug 12, 2019
acud
reviewed
Aug 14, 2019
zelig
suggested changes
Aug 14, 2019
This was referenced Aug 14, 2019
zelig
suggested changes
Aug 16, 2019
acud
suggested changes
Aug 16, 2019
|
@jmozah see linting error https://travis-ci.org/ethersphere/swarm/jobs/572356780#L491 |
acud
approved these changes
Aug 26, 2019
janos
approved these changes
Aug 26, 2019
zelig
approved these changes
Aug 26, 2019
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: pss: Modularize crypto and remove Whisper. Step 1 - isolate whisper code (ethersphere#1698) pss: Improve pressure backstop queue handling - no mutex (ethersphere#1695) cmd/swarm-snapshot: if 2 nodes to create snapshot use connectChain (ethersphere#1709) network: Add API for Capabilities (ethersphere#1675) pss: fixed flaky test that was using a global variable instead of a local one (ethersphere#1702) pss: Port tests to `network/simulation` (ethersphere#1682) storage: fix hasherstore seen check to happen when error is nil (ethersphere#1700) vendor: upgrade go-ethereum to 1.9.2 (ethersphere#1689) bzzeth: initial support for bzz-eth protocol (ethersphere#1571) network/stream: terminate runUpdateSyncing on peer quit (ethersphere#1696) all: first working SWAP version (ethersphere#1554) version: update to v0.5.0 unstable (ethersphere#1694) chunk, storage: storage with multi chunk Set method (ethersphere#1684) chunk, storage: add HasMulti to chunk.Store (ethersphere#1686) chunk, shed, storage: chunk.Store GetMulti method (ethersphere#1691) api, chunk: progress bar support (ethersphere#1649)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the HTTP api support to retrieve tag counters.
A new endpoint /bzz-tag/ is added to achieve this.
Instead of supplying the swarm hash, the tagID can also be supplied like /bzz-tag/?tagID=
The tag id of a uploaded file is returned in the response header.
Any client which wants to implement a progress bar will get this tagId and pull the counters using this API.