Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

pss: disable TestForwardBasic #1544

Merged
merged 1 commit into from
Jul 11, 2019
Merged

pss: disable TestForwardBasic #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pss/forwarding_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ var testCases []testCase
// selects the peers for message forwarding, depending on the message address
// and kademlia constellation.
func TestForwardBasic(t *testing.T) {
t.Skip("Flaky on macOS on local machines")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the skip message, can we skip it only if GOOS is darwin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if this works fine on other platforms. If it is indeed a macOS issue, then sure, but I don't know if this is the case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sorry, a precise message gave me the impression that is the problem only on macOS, my mistake...

baseAddrBytes := make([]byte, 32)
for i := 0; i < len(baseAddrBytes); i++ {
baseAddrBytes[i] = 0xFF
Expand Down