This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm, p2p: Prerequities for ENR replacing handshake #1296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolash
changed the title
janos
reviewed
Mar 13, 2019
There was a problem hiding this comment.
Some calls to p2ptest.NewProtocolTester needs to be updated:
p2p/protocols/protocol_test.go:264:38:warning: unused variable or constant cannot use conf.ID (variable of type enode.ID) as *ecdsa.PrivateKey value in argument to p2ptest.NewProtocolTester (varcheck)
p2p/protocols/protocol_test.go:148:35:warning: unused variable or constant cannot use conf.ID (variable of type enode.ID) as *ecdsa.PrivateKey value in argument to p2ptest.NewProtocolTester (varcheck)
p2p/testing/protocoltester.go
Outdated
| } | ||
| if err := net.Start(peers[i].ID); err != nil { | ||
| panic(fmt.Sprintf("error starting peer %v: %v", peers[i].ID, err)) | ||
| panic(err.Error()) |
There was a problem hiding this comment.
The second panic impossible to happen.
| @@ -0,0 +1,70 @@ | |||
| package network | |||
There was a problem hiding this comment.
Why to move this code to file named types.go? This utility names should be avoided. I propose name network.go instead types.go.
janos
approved these changes
Mar 13, 2019
zelig
approved these changes
Mar 15, 2019
swarm/api/config.go
Outdated
| pubkey := crypto.FromECDSAPub(&prvKey.PublicKey) | ||
| pubkeyhex := common.ToHex(pubkey) | ||
| keyhex := crypto.Keccak256Hash(pubkey).Hex() | ||
| //keyhex := crypto.Keccak256Hash(pubkey).Hex() |
53 tasks
|
submitted upstream ethereum/go-ethereum#19275 |
|
upstream merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some preliminary changes to allow for using ENR to transmit the swarm overlay address between peers.
Currently, ENR is not being sent over the p2p handshake. The necessary changes for this to happen is pending an EIP submission (and approval, and implementation). This is described in this PR by @fjl which incidentally also contains a hack by him that provides a functional demonstration on how ENR record will be available through
PeerInfoand on thep2p.Peerobject:ethereum/go-ethereum#19220
In the meantime, the aim is to include the maximum amount of changes here that can be made towards the goal without relying on the implementation of the EIP. Some of the changes are cherry-picked from an experimental branch https://github.com/ethersphere/go-ethereum/tree/enr-bzz-poc building on the in the above mentioned PR.
In the experimental branch all handshake related code has been removed, and includes a temporary POC test
swarm/network/simulation/protocol_new_test.go:TestENRthat demonstrates a successfulWaitTillHealthy()only using ENR.My proposed steps towards the basic but sound transition to handshake-free Swarm are:
BEFORE EIP
AFTER EIP
swarm/networkswarm/network:BzzAddrswarm/network:BzzPeerandswarm/network:Peerp2p/protocolsp2p/protocolstoswarmpackage