This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network: hive SuggestPeer unit tests #1088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kademlia, test now "passes"
53 tasks
zelig
reviewed
Jan 3, 2019
| RetryInterval: 4200000000, // 4.2 sec | ||
| //RetryExponent: 2, | ||
| RetryExponent: 3, | ||
| RetryExponent: 3, |
There was a problem hiding this comment.
i just removed the commented one. was it 2 in the first place?
swarm/network/hive.go
Outdated
| } | ||
|
|
||
| func (h *Hive) isTimeForRetry(d *Peer) bool { | ||
| // debug.PrintStack() |
There was a problem hiding this comment.
this comment is for getRetriesFromDuration ON LINE 511
what is this?
div += (150000 - rand.Int63n(300000)) * div / 1000000
There was a problem hiding this comment.
not sure i understand the question. anyway removed by now
zelig
reviewed
Jan 4, 2019
| seqPo++ | ||
| // stop if we reach depth, because peers from that point and deeper will be treated differently | ||
| if po <= depth { | ||
| if depth >= po { |
swarm/network/hive.go
Outdated
| return callablePeers | ||
| } | ||
|
|
||
| func insertSort(arr []int, comp func(int, int) bool) { |
|
Discontinued due to ethereum/go-ethereum#18404 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.