fix(retrieval, pushsync): missing full close on streams #5295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
It is observed that strange stream resets were happening on testnet clusters:
This PR solved the issue that cause such errors. It is required to proprely close the channel in case that the final message with the internal error is sent.
Regression tests are made that use the real libp2p server in order to reproduce this problem. They may be a bit too much integrational, but they are needed for validating that the issue and the fix. If the FullClose is removed, the tests are failing with the same log messages as on real infrastructure.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):