chore: golang 1.24 #5053
Draft
chore: golang 1.24 #5053
+260
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
reviewed
Mar 18, 2025
| github.com/libp2p/go-libp2p v0.33.2 | ||
| github.com/multiformats/go-multiaddr v0.12.3 | ||
| github.com/multiformats/go-multiaddr-dns v0.3.1 | ||
| github.com/libp2p/go-libp2p v0.41.0 |
There was a problem hiding this comment.
Updating the libp2p library could be quite sensitive, I would suggest to do the update in a separate PR and test that all things work well.
|
My recommendation would be that we should update most of the libraries separate one from each other and separate from upgrading to the new Go version. Doing this we can avoid struggling to find possible issues/incompatibilities that might come with the new updates. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):