Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix types #4156

Closed
wants to merge 2 commits into from
Closed

fix types #4156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bc3816
fix typo
Ankush263 Jun 16, 2023
f76a651
fix types of indexed & result
Ankush263 Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src.ts/abi/fragments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ export class ParamType {
comps = null;
}

let indexed = null;
let indexed: null | boolean = null;
const keywords = consumeKeywords(obj, KwModifiers);
if (keywords.has("indexed")) {
if (!allowIndexed) { throw new Error(""); }
Expand Down Expand Up @@ -1061,7 +1061,7 @@ export class ErrorFragment extends NamedFragment {
});
}

const result = [ ];
const result: any = [ ];
if (format !== "sighash") { result.push("error"); }
result.push(this.name + joinParams(format, this.inputs));
return result.join(" ");
Expand Down Expand Up @@ -1136,7 +1136,7 @@ export class EventFragment extends NamedFragment {
});
}

const result = [ ];
const result: any = [ ];
if (format !== "sighash") { result.push("event"); }
result.push(this.name + joinParams(format, this.inputs));
if (format !== "sighash" && this.anonymous) { result.push("anonymous"); }
Expand Down Expand Up @@ -1435,7 +1435,7 @@ export class FunctionFragment extends NamedFragment {
});
}

const result = [];
const result: any = [];

if (format !== "sighash") { result.push("function"); }

Expand Down
2 changes: 1 addition & 1 deletion src.ts/contract/contract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ export class BaseContract implements Addressable, EventEmitterable<ContractEvent
Object.defineProperty(this, internal, { value: { } });

let addrPromise;
let addr = null;
let addr: null | string = null;

let deployTx: null | ContractTransactionResponse = null;
if (_deployTx) {
Expand Down