Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change projectId variable name to APIKey in Infura provider #3929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reza-sadeghzadeh
Copy link

I was in the middle of testing my project when I kept getting a 401 Unauthorized error. I couldn't figure out what was causing this error until I realized that I had been providing the wrong credentials for the Infura provider.
After checking out the documentation, I found out that one of the property names had been changed to something else. According to the documentation, "The API key was previously called the project ID" As soon as I corrected this mistake, the 401 Unauthorized error disappeared, and I was able to resume testing my project without any issues. Link to the Infura page

This PR involves modifying the name of a variable in the codebase. After the build scripts are executed, the updated variable name will be reflected in the compiled build.

@reza-sadeghzadeh reza-sadeghzadeh changed the title change projectId variable name to APIKey change projectId variable name to APIKey in Infura provider Mar 24, 2023
@ricmoo
Copy link
Member

ricmoo commented Mar 24, 2023

This is unfortunately a non-backwards compatible change and cannot be made until the next major version bump.

In the next minor bump, I could possibly add it as an alias, if it matters?

@reza-sadeghzadeh
Copy link
Author

Thank you for explaining the situation and considering my PR.
I'll continue to work with the current version and I appreciate your willingness to add it as an alias in the next minor version.

@ricmoo ricmoo added major-bump Planned for the next major version bump minor-bump Planned for the next minor version bump. v6 Issues regarding v6 labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-bump Planned for the next major version bump minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants