Improve ethers.utils.parseUnits error message

[jeffprestes]

Getting this error:
ethers-5.0.umd.min.js:1 Uncaught Error: invalid decimal value (argument="value", value=1, code=INVALID_ARGUMENT, version=bignumber/5.0.5)

in this statement

    value: ethers.utils.parseUnits(amount, "gwei"),
  };```

in amount variable the value is 1

In ethers 4.0 it works.

[ricmoo]

The value must be a string... if it worked in v4, that was probably a bug... Numbers are not safe to use in parseUnits as arithmetic underflow could occur.

The string "1" should be fine though. :)

[jeffprestes]

You're right. Thanks for the quick answer!
BTW, I'll let update the issue to improve the error message to let this situation more clear to lib user.
I wish I could help but as I am not typescript I can't do it unfortunately.

[jeffprestes]

ethers.js/packages/bignumber/src.ts/fixednumber.ts

Line 72 in 96cb440

logger.throwArgumentError("invalid decimal value", "value", value);

[ricmoo]

That’s is a completely fair ask.

I’m in the midst of moving this week, but will get to this soon. :)

[ricmoo]

This has been fixed in 5.0.17. If you have any problems, please let me know.

Thanks! :)

[jeffprestes]

Thanks Ric. I believe it's going to help some Devs.

[CodeLuca]

helped me a ton

[mairura]

This is helpful. I appreciate alot