Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTransactionReceipt to field is undefined in version 5 #573

Closed
naddison36 opened this issue Jul 29, 2019 · 3 comments
Closed

getTransactionReceipt to field is undefined in version 5 #573

naddison36 opened this issue Jul 29, 2019 · 3 comments
Labels
enhancement New feature or improvement.

Comments

@naddison36
Copy link

In version 4, the to field in a transaction receipt from a contract deployment transaction would be null.
In version 5, the to field in a transaction receipt from a contract deployment transaction is undefined.

I think it should be null like version 4.
@ricmoo
Copy link
Member

ricmoo commented Oct 19, 2019

I agree. :)

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label Oct 19, 2019
ricmoo added a commit that referenced this issue Oct 19, 2019
@ricmoo
Force deploy receipt to address to be null (#573).
d9d438a
@ricmoo
Copy link
Member

ricmoo commented Oct 19, 2019

I've made the change and tested it locally. I will hold off on publishing it until I've accumulated a few more changes, unless you need it more urgently.

Thanks! :)

@ricmoo ricmoo added enhancement New feature or improvement. and removed on-deck This Enhancement or Bug is currently being worked on. labels Oct 19, 2019
@ricmoo
Copy link
Member

ricmoo commented Nov 24, 2019

This has been published. Let me know if you have any problems with it.

Thanks! :)

@ricmoo ricmoo closed this as completed Nov 24, 2019
michaeltout pushed a commit to michaeltout/ethers.js that referenced this issue Aug 23, 2020
@ricmoo
Force deploy receipt to address to be null (ethers-io#573).
def4fec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @naddison36