Source maps are lost during bundling.

[MicahZoltu]

The sourcemap for ethers.min.js is not the original easy-to-read TypeScript, but instead the compiled TypeScript output. The build system appears to be dropping the TypeScript sourcemap when minifying/bundling down to ethers.min.js. It would be nice if the build system kept the original TypeScript in the source map instead.

I think most major build tools know how to merge sourcemaps, so if you are generating TS source maps the bundler/minifier should be able to turn those into a single bundled source map. Of course, the process is different for every bundler.

[ricmoo]

Would love assistance on this, if you know how to get the tools to knock out the right map files. :)

[MicahZoltu]

It may be as simple as adding "sourceMap": true to https://github.com/ethers-io/ethers.js/blob/master/tsconfig.json#L3-L23. I would recommend trying that first and seeing if everything else "just works". If not, you'll need to illicit support from someone familiar with your particular set of build tools, which looks like browserify based on dependencies?

Either way, I recommend adding "sourceMap": true as it will make debugging in nodejs a tad better at least, even if it doesn't help with browser due to the maps getting lost during minification.

[ricmoo]

Is this still an issue in v5? If so, anyone who can demonstrate how to fix it, let me know. Otherwise I may close this soon.

Thanks! :)

[MicahZoltu]

Looking at https://github.com/ethers-io/ethers.js/blob/master/tsconfig.package.json, the answer appears to be "yes this is still an issue" since that is still missing the source maps flag. I can't say whether that alone will fix it (I believe you use a bundler, which needs to do the right thing with the source TS source maps), but I can say with quite a bit of confidence that without the fix I described above, you definitely won't have functional source maps.

[ricmoo]

I believe this should be fixed now. Source maps are carried through the build process and with the aid of source-map-support, I even get the TypeScript location and context of errors now.

Let me know if your milage differs, otherwise I'll close this. :)

[MicahZoltu]

I'm not using ethers.js in any projects at the moment, so I cannot test myself. It may be worth also adding https://www.staging-typescript.org/tsconfig#declarationMap as well to improve developer experience (it is a relatively new addition to TS), but that is unrelated to the source map problem.

[ricmoo]

I've added declaration maps in 5.0.27.

If you have any issues, please let me know. :)