Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockTag should be able to take bigint as input #3780

Closed
zfy0701 opened this issue Feb 15, 2023 · 2 comments
Closed

blockTag should be able to take bigint as input #3780

zfy0701 opened this issue Feb 15, 2023 · 2 comments
Assignees
@ricmoo
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6

Comments

@zfy0701
Copy link

zfy0701 commented Feb 15, 2023

Ethers Version

6.0.2

Search Terms

No response

Describe the Problem

currently it's only accept number, but blockNumber could be bigint in many cases.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response
@zfy0701 zfy0701 added the investigate Under investigation and may be a bug. label Feb 15, 2023
@ricmoo
Copy link
Member

ricmoo commented Feb 15, 2023

You are absolutely correct. I will get this in for the v6.1 later this week. :)

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 minor-bump Planned for the next minor version bump. and removed investigate Under investigation and may be a bug. labels Feb 15, 2023
ricmoo added a commit that referenced this issue Mar 4, 2023
@ricmoo
Allow BigInt for blockTag (#3780).
fe1f04c
@ricmoo
Copy link
Member

ricmoo commented Mar 7, 2023

Added in v6.1.0. Let me know if there are any problems.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 7, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 7, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Allow BigInt for blockTag (ethers-io#3780).
5b9e7b9
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Allow BigInt for blockTag (ethers-io#3780).
e99862f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @zfy0701