Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethers v6: missing listAccounts() function for browserProvider? #3778

Closed
orenyomtov opened this issue Feb 14, 2023 · 7 comments
Closed

Ethers v6: missing listAccounts() function for browserProvider? #3778

orenyomtov opened this issue Feb 14, 2023 · 7 comments
Assignees
@ricmoo
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6

Comments

@orenyomtov
Copy link

Ethers Version

6.0.3

Search Terms

No response

Describe the Problem

How can i get the list of accounts provided by the wallet?
In v5 I used provider.listAccounts()

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response
@orenyomtov orenyomtov added the investigate Under investigation and may be a bug. label Feb 14, 2023
@ricmoo
Copy link
Member

ricmoo commented Feb 14, 2023

That has not changed…

@orenyomtov
Copy link
Author

image

@ricmoo Maybe it's a Typescript problem?

@orenyomtov
Copy link
Author

While I'm at it although it's not relevant... I see ethers.utils.signTypedData is no longer present - what is the proposed alternative?

@dabit3
Copy link

dabit3 commented Feb 17, 2023

+1, is there a way to list accounts with the new API (BrowserProvider) for the time being as a workaround?

@ricmoo
Copy link
Member

ricmoo commented Feb 18, 2023

It does look like I missed it in v6. I’ll add it back in v6.1. Thanks!

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. v6 Issues regarding v6 and removed investigate Under investigation and may be a bug. labels Feb 18, 2023
@ricmoo ricmoo mentioned this issue Feb 24, 2023
Closed
ricmoo added a commit that referenced this issue Mar 4, 2023
@ricmoo
Added listAccounts to JsonRpcProvider (#3778).
287d94f
@ricmoo
Copy link
Member

ricmoo commented Mar 7, 2023

Added in v6.1.0. Let me know if you still have any issues.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 7, 2023
@dabit3
Copy link

dabit3 commented Mar 7, 2023

LFG, thank you @ricmoo !

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 21, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Added listAccounts to JsonRpcProvider (ethers-io#3778).
11b818b
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Added listAccounts to JsonRpcProvider (ethers-io#3778).
e296291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orenyomtov @ricmoo @dabit3