Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing exports for v6.1 #3734

Closed
ricmoo opened this issue Feb 5, 2023 · 8 comments
Closed

Adding missing exports for v6.1 #3734

ricmoo opened this issue Feb 5, 2023 · 8 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6

Comments

@ricmoo
Copy link
Member

ricmoo commented Feb 5, 2023

Describe the Feature

This issue is to help track which exports need to be added in v6.1. The most recent Flatworm is having logic introduced to detect missing root exports, which currently reports:

// Missing concrete objects
export {
    ErrorDescription, FallbackFragment, NamedFragment, StructFragment
} from "abi/index.ts"
export {
    ContractUnknownEventPayload
} from "contract/index.ts"
export {
    EnsPlugin, EtherscanPlugin, FeeDataNetworkPlugin, GasCostPlugin, InfuraWebSocketProvider,
    NetworkPlugin, SocketBlockSubscriber, SocketEventSubscriber, SocketPendingSubscriber,
    SocketSubscriber, UnmanagedSubscriber, copyRequest, showThrottleMessage
} from "providers/index.ts"
export {
    EventPayload, resolveProperties, uuidV4
} from "utils/index.ts"
export {
    wordlists
} from "wordlists/index.ts"

// Missing types
export type {
    FormatType, FragmentType
} from "abi/index.ts"
export type {
    AddressLike, NameResolver
} from "address/index.ts"
export type {
    BaseContractMethod, ContractDeployTransaction, PostfixOverrides
} from "contract/index.ts"
export type {
    AbstractProviderPlugin, BlockParams, BlockTag, ContractRunner, DebugEventBrowserProvider,
    Eip1193Provider, EventFilter, Filter, FilterByBlockHash, GasCostParameters,
    JsonRpcApiProviderOptions, JsonRpcError, JsonRpcPayload, JsonRpcResult,
    JsonRpcTransactionRequest, LogParams, MinedBlock, MinedTransactionResponse, Networkish,
    OrphanFilter, PerformActionFilter, PerformActionRequest, PerformActionTransaction,
    PreparedTransactionRequest, ProviderEvent, Subscriber, Subscription, TopicFilter,
    TransactionReceiptParams, TransactionRequest, TransactionResponseParams,
    WebSocketCreator, WebSocketLike
} from "providers/index.ts"
export type {
    CallExceptionAction, CallExceptionTransaction, EventEmitterable, Listener
} from "utils/index.ts"
export type {
    CrowdsaleAccount
} from "wallet/index.ts"

Code Example

No response

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 labels Feb 5, 2023
@wei3erHase
Copy link

is it supposed to fix this error?
image

@ricmoo
Copy link
Member Author

ricmoo commented Feb 17, 2023

@wei3erHase I dont believe so. Looks like you are setting nonce to null, where you should leave it undefined or set it to undefined.

It prolly makes sense to allow null though. I can add that for v6.1.

@ricmoo ricmoo added the minor-bump Planned for the next minor version bump. label Feb 18, 2023
@songkeys
Copy link

songkeys commented Feb 23, 2023

ExternalProvider, JsonRpcFetchFunc doesn't seem to exist anymore?

@ricmoo
Copy link
Member Author

ricmoo commented Feb 23, 2023

In v6, it’s now Eip1193Provider.

The ExternalProvider in v5 was designed to support EIP-1193 Providers and legacy-era (0.20.0) Web3.js providers. But modern Web3.js providers actually implement the EIP-1193 standard, so it’s much easier to interact with. :)

@wei3erHase
Copy link

@ricmoo , discovered that ContractTransaction is the replacement for such class

@joewagner
Copy link

@ricmoo Thanks for opening this, getting a fix in the works.
NRE, but wanted to add a +1 to get this included in v6.1.
I help maintain an SDK built with Typescript that uses ethers and as far as I can tell, since Eip1193Provider is not exported there is no way for us to upgrade.

@jim380
Copy link

jim380 commented Mar 6, 2023

Finally. can't wait @ricmoo 🙏

@ricmoo
Copy link
Member Author

ricmoo commented Mar 7, 2023

These have been added in v6.1.0.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 7, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 7, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

No branches or pull requests

5 participants