Wrong arrayify left padding

[ceo-domido]

Ethers Version

5.6.1

Search Terms

No response

Describe the Problem

ethers.utils.arrayify function has undocumented option hexPad with values "left" and "right". In the case of "right", everything is correct, but the "left" option get the wrong result because of the double input string cutting in lines 118 and 121
The correct lines 117-127 should be the following:

if (isHexString(value)) {
    let hex = (<string>value).substring(2);
    if (hex.length % 2) {
        if (options.hexPad === "left") {
            hex = "0" + hex;  // instead of hex = "0x0" + hex.substring(2);
        } else if (options.hexPad === "right") {
            hex += "0";
        } else {
            logger.throwArgumentError("hex data is odd-length", "value", value);
        }
    }
  

### Code Snippet

```shell
const utils = require("ethers/lib/utils");
console.log(utils.arrayify("0x0", {hexPad: "right"}));
console.log(utils.arrayify("0x1", {hexPad: "right"}));
// Uint8Array(1) [ 0 ]
// Uint8Array(1) [ 16 ]
console.log(utils.arrayify("0x0", {hexPad: "left"}));
console.log(utils.arrayify("0x1", {hexPad: "left"}));
// Uint8Array(2) [ 0, 0 ]
// Uint8Array(2) [ 0, 0 ]

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response

[ricmoo]

Fixed in v5.6.2. :)

Let me know if you have any issues.

Thanks for finding this! :)