Can't catch Unhandled Rejection (Error): resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.0.8)

[0xmikko]

Hi! I run this code in browser, and can't catch promise rejection.
Important: I added await before getContract,however in typings you return Contract, not Promise but the code throw promise rejection!

Code:
let vault;
try {
vault = (await ethers.ContractFactory.getContract(
CONTRACT_ADDRESS,
vaultJson.abi,
signer
) as unknown) as Vault;
} catch (e) {
console.log("Error getting contract");
return;
}

Expected behavior:
Rejection in getContract would be caught in try-catch block

Real outcome:
Unhandled Rejection (Error): resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.0.8)

[ricmoo]

Thanks! I’ll look into this shortly...

[0xmikko]

Typings for ethers:
static getContract(address: string, contractInterface: ContractInterface, signer?: Signer): Contract;

[0xmikko]

Code:

      try {
        vault = (await ethers.ContractFactory.getContract(
          CONTRACT_ADDRESS,
          vaultJson.abi,
          signer
        ) as unknown) as Vault;
      } catch (e) {
        console.log("Error getting contract");
        return;
      }

[0xmikko]

To clarify the issue, I test this code especially for throwing error, passing CONTRACT_ADDRESS=undefined to check behavior in my app when error occurs. I expect that the error should be catched.

[ricmoo]

I agree. Errors should be recoverable using normal JavaScript conventions. :)

[ricmoo]

(you shouldn’t need to await)

[0xmikko]

Okay, I added await after getting an error of unhandled promise - which I perceived that there are some async code there. Unfortunately, I got the same behavior without await also.

[ricmoo]

Yeah. The await will have no effect. I need to swallow the error. It won’t throw an error in general though, since that resolution of ENS name to address is async.

In your case though, I can add a condition that throws if address is not a string, so you will get a sync error for you. But in general it won’t fail for users who pass in an invalid string until they try calling a method on the Contract.

I’ll check into these changes tomorrow and kinda trace through some behaviour to make sure it all still makes sense. :)

[0xmikko]

The same behavior with empty string also:

 let vault;
      try {
        vault = (ethers.ContractFactory.getContract(
          CONTRACT_ADDRESS || "",
          vaultJson.abi,
          signer
        ) as unknown) as Vault;
      } catch (e) {
        console.log("Error getting contract");
        return;
      }

This is stack trace:

    makeError index.ts:205
    throwError index.ts:217
    throwArgumentError index.ts:221
    resolveName index.ts:117
    fulfilled 0.chunk.js:5105
    promise callback*step 0.chunk.js:5120
    fulfilled 0.chunk.js:5105
    promise callback*step 0.chunk.js:5120
    node_modules 0.chunk.js:5123
    node_modules 0.chunk.js:5102
    resolveName 0.chunk.js:5153
    Contract index.ts:663
    getContract index.ts:1210

[0xmikko]

Any update?